From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] Don't register integrity profile for disabled disks
Date: Wed, 06 Aug 2008 14:46:41 -0400 [thread overview]
Message-ID: <yq1promugku.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1218046669.7493.36.camel@localhost.localdomain> (James Bottomley's message of "Wed\, 06 Aug 2008 11\:17\:49 -0700")
>>>>> "James" == James Bottomley <James.Bottomley@HansenPartnership.com> writes:
James> This is a possible thing to have happen for devices with SCSI-2
James> reservations ... and that's not a permanenet condition. When
James> the reservation is released, tools usually do a BLKRRPART, but
James> that won't pick up the DIF information ... perhaps this should
James> be in sd_revalidate_disk?
sd_revalidate_disk can be called before the gendisk exists so I can't
register the profile from there. At one point I tried shuffling
add_disk and revalidate in sd_probe but that caused problems with
sysfs.
I haven't tried reordering since the SCSI sysfs revamp. I'll try that
out so just drop the patch for now. It's mostly cosmetic anyway.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2008-08-06 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 18:08 [PATCH] Don't register integrity profile for disabled disks Martin K. Petersen
2008-08-06 18:17 ` James Bottomley
2008-08-06 18:46 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1promugku.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox