Re: [PATCH v11 00/10] Read/Write with meta/integrity

Christoph Hellwig
2025-06-04T07:30:23Z

On Wed, Jun 04, 2025 at 12:45:44PM +0530, Anuj gupta wrote:
> The fio plumbing I had done for testing was pretty hacky (e.g., using
> NVMe ioctls directly to query PI capabilities), so I didn’t send it
> upstream. I plan to submit a liburing test. While working on it, I
> realized that writing generic userspace tests is tricky without a way to
> query the device’s integrity capabilities. The current sysfs interface
> is limited — it doesn't expose key fields like pi_size or metadata_size,
> which are necessary to correctly prepare protection information in
> userspace.
>
> That’s what motivated the ioctl RFC I sent earlier — to make it feasible
> for userspace to construct metadata buffers correctly. Once it gets
> settled, I can write some tests using it. Do you see this differently?

Ok, I'll wait for it. In the meantime I might go ahead with just
converting the data path in nvme to the new DMA API and handle the
metadata mapping later.