From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Bodo Stroesser <bostroesser@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
Xiaoguang Wang <xiaoguang.wang@linux.alibaba.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page
Date: Tue, 17 May 2022 21:52:00 -0400 [thread overview]
Message-ID: <yq1r14rmwum.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20220517192913.21405-1-bostroesser@gmail.com> (Bodo Stroesser's message of "Tue, 17 May 2022 21:29:13 +0200")
Bodo,
> In tcmu_blocks_release, lock_page() is called to prevent a race
> causing possible data corruption. Since lock_page() might sleep,
> calling it while holding XArray lock is a bug.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-05-18 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 19:29 [PATCH] scsi: target: tcmu: Avoid holding XArray lock when calling lock_page Bodo Stroesser
2022-05-18 1:52 ` Martin K. Petersen [this message]
2022-05-20 1:09 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r14rmwum.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bostroesser@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=xiaoguang.wang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox