From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Lee Duncan <lduncan@suse.com>,
Mike Christie <michael.christie@oracle.com>,
Chris Leech <cleech@redhat.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
open-iscsi@googlegroups.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: iscsi: fix harmless double shift bug
Date: Mon, 25 Apr 2022 22:36:01 -0400 [thread overview]
Message-ID: <yq1r15kwoza.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <YmFyWHf8nrrx+SHa@kili> (Dan Carpenter's message of "Thu, 21 Apr 2022 18:03:52 +0300")
Dan,
> These flags are supposed to be bit numbers. Right now they cause a
> double shift bug where we use BIT(BIT(2)) instead of BIT(2).
> Fortunately, the bit numbers are small and it's done consistently so
> it does not cause an issue at run time.
Applied to 5.19/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-04-26 2:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 15:03 [PATCH] scsi: iscsi: fix harmless double shift bug Dan Carpenter
2022-04-21 15:38 ` Mike Christie
2022-04-21 16:14 ` Lee Duncan
2022-04-22 8:20 ` Antw: [EXT] " Ulrich Windl
2022-04-26 2:36 ` Martin K. Petersen [this message]
2022-05-03 0:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1r15kwoza.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=cleech@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lduncan@suse.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox