Re: [PATCH] scsi: ips: fix missing break in switch

Finn Thain
2018-10-16T22:27:45Z

On Tue, 16 Oct 2018, Martin K. Petersen wrote:

>
> Gustavo,
>
> > Add missing break statement in order to prevent the code from falling
> > through to case TEST_UNIT_READY.
>
> Applied to 4.20/scsi-queue, thanks!
>
>

This looks wrong to me. I think you've just prevented all START STOP
commands sent to logical volumes from reaching

return ((*ha->func.issue) (ha, scb));

I think a better patch is to add a "fall though" comment not a "break"
statement. (I no longer have access to a ServeRAID board so I can't test.)

--