From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [patch v2] scsi_dh_alua: uninitialized variable in alua_rtpg() Date: Fri, 15 Apr 2016 16:26:51 -0400 Message-ID: References: <20160414182034.GA32469@mwanda> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20160414182034.GA32469@mwanda> (Dan Carpenter's message of "Thu, 14 Apr 2016 21:20:34 +0300") Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Hannes Reinecke , Bart Van Assche , Johannes Thumshirn , Ewan Milne , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-scsi@vger.kernel.org >>>>> "Dan" == Dan Carpenter writes: Dan> It's possible to use "err" without initializing it. If it happens Dan> to be a 2 which is SCSI_DH_RETRY then that could cause a bug. Bart Dan> Van Assche pointed out that we should probably re-initialize it for Dan> every iteration through the retry loop. Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering