Re: [PATCH] target: add iscsi/cpus_allowed_list in configfs

Mike Christie
2022-02-16T17:13:49Z

On 2/9/22 5:48 AM, Zou Mingzhe wrote:
>>>   +cpumask_t __iscsi_allowed_cpumask;
>> Maybe better to put this in iscsi_target.c with the other vars like
>> it.
>
> Originally I wanted to put it in struct iscsit_global and use it in iscsit_thread_check_cpumask.
>
> However iscsit_thread_check_cpumask is also called in cxgbit_target.c. I don't know if I also
>
> need to modify cxgbit at the same time, and I only modified two calls in iscsi_target.c. I would
>

The new configfs file shows up for software iscsi and cxgb right? If so I think you need to
modify both, or you end up with a file that returns success but doesn't do anything and it's
confusing to users. It's also a simple change to cxgb.

> like to know how to handle in cxgbit_target.c?
>
> I want to move 'static inline void iscsit_thread_check_cpumask' from iscsi_target_core.h to
>
> iscsi_target.c and EXPORT_SYMBOL(iscsit_thread_check_cpumask). Do you agree it?
>

I think that is ok.