* [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()
@ 2018-01-08 12:49 Xiongfeng Wang
2018-01-08 16:43 ` Arnd Bergmann
2018-01-09 2:54 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Xiongfeng Wang @ 2018-01-08 12:49 UTC (permalink / raw)
To: suganath-prabu.subramani
Cc: MPT-FusionLinux.pdl, linux-scsi, linux-kernel, wangxiongfeng2,
arnd
From: Xiongfeng Wang <xiongfeng.wang@linaro.org>
gcc-8 reports
drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 100 equals destination size [-Wstringop-truncation]
We need to use strlcpy() to make sure the dest string is
nul-terminated.
Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
---
drivers/message/fusion/mptbase.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
index 7a93400..3c47888 100644
--- a/drivers/message/fusion/mptbase.c
+++ b/drivers/message/fusion/mptbase.c
@@ -7697,7 +7697,7 @@ static void seq_mpt_print_ioc_summary(MPT_ADAPTER *ioc, struct seq_file *m, int
break;
}
if (ds)
- strncpy(evStr, ds, EVENT_DESCR_STR_SZ);
+ strlcpy(evStr, ds, EVENT_DESCR_STR_SZ);
devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()
2018-01-08 12:49 [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy() Xiongfeng Wang
@ 2018-01-08 16:43 ` Arnd Bergmann
2018-01-09 2:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Arnd Bergmann @ 2018-01-08 16:43 UTC (permalink / raw)
To: Xiongfeng Wang
Cc: Suganath Prabu Subramani, MPT-FusionLinux.pdl, linux-scsi,
Linux Kernel Mailing List
On Mon, Jan 8, 2018 at 1:49 PM, Xiongfeng Wang
<wangxiongfeng2@huawei.com> wrote:
> From: Xiongfeng Wang <xiongfeng.wang@linaro.org>
>
> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is
> nul-terminated.
>
> Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Looks correct to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy()
2018-01-08 12:49 [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy() Xiongfeng Wang
2018-01-08 16:43 ` Arnd Bergmann
@ 2018-01-09 2:54 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-01-09 2:54 UTC (permalink / raw)
To: Xiongfeng Wang
Cc: suganath-prabu.subramani, MPT-FusionLinux.pdl, linux-scsi,
linux-kernel, arnd
Xiongfeng,
> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is
> nul-terminated.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-09 2:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-08 12:49 [PATCH] scsi: mptfusion: use strlcpy() instead of strncpy() Xiongfeng Wang
2018-01-08 16:43 ` Arnd Bergmann
2018-01-09 2:54 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).