* [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits()
@ 2017-09-13 14:29 Lukas Czerner
2017-09-13 17:32 ` Bart Van Assche
2017-09-15 1:09 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Lukas Czerner @ 2017-09-13 14:29 UTC (permalink / raw)
To: linux-scsi; +Cc: Lukas Czerner
After series of changes around WRITE_SAME and UNMAP setup we ended up
with leftover unnecessary condition. Remove it.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
drivers/scsi/sd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 11c1738..fb9f8b5 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2915,8 +2915,6 @@ static void sd_read_block_limits(struct scsi_disk *sdkp)
sd_config_discard(sdkp, SD_LBP_WS16);
else if (sdkp->lbpws10)
sd_config_discard(sdkp, SD_LBP_WS10);
- else if (sdkp->lbpu && sdkp->max_unmap_blocks)
- sd_config_discard(sdkp, SD_LBP_UNMAP);
else
sd_config_discard(sdkp, SD_LBP_DISABLE);
}
--
2.7.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits()
2017-09-13 14:29 [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits() Lukas Czerner
@ 2017-09-13 17:32 ` Bart Van Assche
2017-09-15 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2017-09-13 17:32 UTC (permalink / raw)
To: linux-scsi@vger.kernel.org, lczerner@redhat.com
On Wed, 2017-09-13 at 16:29 +0200, Lukas Czerner wrote:
> After series of changes around WRITE_SAME and UNMAP setup we ended up
> with leftover unnecessary condition. Remove it.
A similar patch was sitting in my tree and waiting to be posted. But since you
posted this first:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits()
2017-09-13 14:29 [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits() Lukas Czerner
2017-09-13 17:32 ` Bart Van Assche
@ 2017-09-15 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-09-15 1:09 UTC (permalink / raw)
To: Lukas Czerner; +Cc: linux-scsi
Lukas,
> After series of changes around WRITE_SAME and UNMAP setup we ended up
> with leftover unnecessary condition. Remove it.
Yeah, lbprz went away and made it redundant. Applied to
4.14/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-15 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-13 14:29 [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits() Lukas Czerner
2017-09-13 17:32 ` Bart Van Assche
2017-09-15 1:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).