From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Ewan D. Milne" <emilne@redhat.com>
Cc: Andrei Borzenkov <arvidjaar@gmail.com>, linux-scsi@vger.kernel.org
Subject: Re: Permanently change thin provisioning method from user space?
Date: Tue, 27 Jun 2017 21:05:52 -0400 [thread overview]
Message-ID: <yq1shikzztb.fsf@oracle.com> (raw)
In-Reply-To: <1498597291.10198.21.camel@localhost.localdomain> (Ewan D. Milne's message of "Tue, 27 Jun 2017 17:01:31 -0400")
Ewan,
> sd_fops->revalidate_disk() will cause the properties that cause the
> provisioning_mode to be evaluated to be re-read, and sd_config_discard()
> to set the determined mode. We might want to re-think this, since the
> user overrode what was probed earlier. However, we might also want to
> automatically handle the storage capabilities changing, so I'm not
> sure.
The intent was for people to use udev to override things. But I guess we
could entertain introducing a flag to distinguish between detected and
configured state.
> My reading of SBC-4r13 6.6.4 is that a WRITE SAME(16) w/UNMAP has
> a length limited by the MAXIMUM WRITE SAME LENGTH, and that is what
> sd.c implements, but I'm suspicious that the array treated a WRITE SAME(16)
> w/UNMAP of 2097152 blocks as an UNMAP and failed it w/ILLEGAL COMMAND,
> INVALID FIELD IN CDB.
Ugh :(
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-06-28 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-27 11:02 Permanently change thin provisioning method from user space? Andrei Borzenkov
2017-06-27 21:01 ` Ewan D. Milne
2017-06-28 1:05 ` Martin K. Petersen [this message]
2017-06-28 4:06 ` Andrei Borzenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1shikzztb.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=arvidjaar@gmail.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox