* [PATCH] scsi: libfc: fix incorrect variable assingment
@ 2017-05-11 22:24 Gustavo A. R. Silva
2017-05-12 12:21 ` Ewan D. Milne
2017-05-17 1:09 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2017-05-11 22:24 UTC (permalink / raw)
To: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen
Cc: fcoe-devel, linux-scsi, linux-kernel, Gustavo A. R. Silva
Previous assignment was causing the use of the uninitialized variable
_explan_ inside fc_seq_ls_rjt() function, which in this particular
case is being called by fc_seq_els_rsp_send().
Addresses-Coverity-ID: 1398125
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
drivers/scsi/libfc/fc_rport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
index b44c313..5203258 100644
--- a/drivers/scsi/libfc/fc_rport.c
+++ b/drivers/scsi/libfc/fc_rport.c
@@ -1422,7 +1422,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata,
fp = fc_frame_alloc(lport, sizeof(*rtv));
if (!fp) {
rjt_data.reason = ELS_RJT_UNAB;
- rjt_data.reason = ELS_EXPL_INSUF_RES;
+ rjt_data.explan = ELS_EXPL_INSUF_RES;
fc_seq_els_rsp_send(in_fp, ELS_LS_RJT, &rjt_data);
goto drop;
}
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libfc: fix incorrect variable assingment
2017-05-11 22:24 [PATCH] scsi: libfc: fix incorrect variable assingment Gustavo A. R. Silva
@ 2017-05-12 12:21 ` Ewan D. Milne
2017-05-17 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Ewan D. Milne @ 2017-05-12 12:21 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen,
fcoe-devel, linux-scsi, linux-kernel
On Thu, 2017-05-11 at 17:24 -0500, Gustavo A. R. Silva wrote:
> Previous assignment was causing the use of the uninitialized variable
> _explan_ inside fc_seq_ls_rjt() function, which in this particular
> case is being called by fc_seq_els_rsp_send().
>
> Addresses-Coverity-ID: 1398125
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
> drivers/scsi/libfc/fc_rport.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
> index b44c313..5203258 100644
> --- a/drivers/scsi/libfc/fc_rport.c
> +++ b/drivers/scsi/libfc/fc_rport.c
> @@ -1422,7 +1422,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata,
> fp = fc_frame_alloc(lport, sizeof(*rtv));
> if (!fp) {
> rjt_data.reason = ELS_RJT_UNAB;
> - rjt_data.reason = ELS_EXPL_INSUF_RES;
> + rjt_data.explan = ELS_EXPL_INSUF_RES;
> fc_seq_els_rsp_send(in_fp, ELS_LS_RJT, &rjt_data);
> goto drop;
> }
s/assingment/assignment/
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: libfc: fix incorrect variable assingment
2017-05-11 22:24 [PATCH] scsi: libfc: fix incorrect variable assingment Gustavo A. R. Silva
2017-05-12 12:21 ` Ewan D. Milne
@ 2017-05-17 1:09 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-05-17 1:09 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Johannes Thumshirn, James E.J. Bottomley, Martin K. Petersen,
fcoe-devel, linux-scsi, linux-kernel
Gustavo A.,
> Previous assignment was causing the use of the uninitialized variable
> _explan_ inside fc_seq_ls_rjt() function, which in this particular
> case is being called by fc_seq_els_rsp_send().
Applied to 4.12/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-05-17 1:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-11 22:24 [PATCH] scsi: libfc: fix incorrect variable assingment Gustavo A. R. Silva
2017-05-12 12:21 ` Ewan D. Milne
2017-05-17 1:09 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox