From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Colin King <colin.king@canonical.com>
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: aacraid: remove redundant zero check on ret
Date: Mon, 27 Feb 2017 22:20:32 -0500 [thread overview]
Message-ID: <yq1shmzvw5b.fsf@oracle.com> (raw)
In-Reply-To: <20170224144330.6707-1-colin.king@canonical.com> (Colin King's message of "Fri, 24 Feb 2017 14:43:30 +0000")
>>>>> "Colin" == Colin King <colin.king@canonical.com> writes:
Colin,
Colin> The check for ret being zero is redundant as a few statements
Colin> earlier we break out of the while loop if ret is non-zero. Thus
Colin> we can remove the zero check and also the dead-code non-zero case
Colin> too.
Applied to 4.11/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-02-28 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 14:43 [PATCH] scsi: aacraid: remove redundant zero check on ret Colin King
2017-02-26 20:01 ` Dave Carroll
2017-02-28 3:20 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1shmzvw5b.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=colin.king@canonical.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox