From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] SCSI: Disable WRITE SAME for RAID and virtual host adapter drivers
Date: Wed, 23 Oct 2013 12:29:32 -0400 [thread overview]
Message-ID: <yq1sivsdk7n.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <20131023161137.GA31895@infradead.org> (Christoph Hellwig's message of "Wed, 23 Oct 2013 09:11:37 -0700")
>>>>> "Christoph" == Christoph Hellwig <hch@infradead.org> writes:
>> @@ -3625,6 +3625,7 @@ int ata_scsi_add_hosts(struct ata_host *host,
>> struct scsi_host_template *sht)
shost-> max_lun = 1; max_channel = 1; max_cmd_len = 16;
>> + shost->no_write_same = 1;
Christoph> Unless I miss something this will disable TRIM support in
Christoph> libata entirely.
The flag effectively disables advertising REQ_WRITE_SAME support to the
block layer (max_write_same_sectors). It doesn't prevent anyone from
issuing write same commands in general. Such as the sd discard prep_fn
and users of sg/bsg.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2013-10-23 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-23 10:25 [PATCH] SCSI: Disable WRITE SAME for RAID and virtual host adapter drivers Martin K. Petersen
2013-10-23 16:11 ` Christoph Hellwig
2013-10-23 16:29 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1sivsdk7n.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox