public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Snitzer <snitzer@redhat.com>
Cc: linux-scsi@vger.kernel.org,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] scsi: relax PAGE LENGTH check for thin provisioning UNMAP support
Date: Thu, 06 May 2010 00:28:10 -0400	[thread overview]
Message-ID: <yq1sk65ejs5.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1273096203-3164-1-git-send-email-snitzer@redhat.com> (Mike Snitzer's message of "Wed, 5 May 2010 17:50:03 -0400")

>>>>> "Mike" == Mike Snitzer <snitzer@redhat.com> writes:

Mike> Thin Provisioning fields are assumed available in the BLOCK LIMITS
Mike> VPD page if PAGE LENGTH is 0x3c.  The BLOCK LIMITS VPD page may be
Mike> extended over time.  Allow for the possibility that the PAGE
Mike> LENGTH exceeds 0x3c.

SBC3 states that: 

"If the device server supports thin provisioning, then the device server
shall set the PAGE LENGTH field to 3Ch."

That's a "shall".  That's a non-negotiable requirement in standards
speak.  And besides, only half of that mandated page length is currently
spoken for.  So I wonder what motivated your change?  Do you have any
examples of devices with a bigger page length?

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2010-05-06  4:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 21:50 [PATCH] scsi: relax PAGE LENGTH check for thin provisioning UNMAP support Mike Snitzer
2010-05-06  4:28 ` Martin K. Petersen [this message]
2010-05-06 11:24   ` Mike Snitzer
2010-05-06 14:27     ` Knight, Frederick
2010-05-07  4:52       ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1sk65ejs5.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox