From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi: target: Fix write perf due to unneeded throttling
Date: Mon, 21 Aug 2023 17:21:44 -0400 [thread overview]
Message-ID: <yq1ttss5byk.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230817192902.346791-1-michael.christie@oracle.com> (Mike Christie's message of "Thu, 17 Aug 2023 14:29:02 -0500")
Mike,
> The write back throttling (WBT) code checks if REQ_SYNC | REQ_IDLE is
> set to determine if a write is O_DIRECT vs buffered. If the bits are
> not set then it assumes it's a buffered write and will throttle LIO if
> we hit certain metrics. LIO itself is not using the buffer cache and
> is doing direct IO, so this has us set the direct bits so we are not
> throttled.
>
> When the initiator application is doing direct IO this can greatly
> improve performance. It depends on the backend device but we have seen
> where the WBT code is throttling writes to only 20K IOPs with 4K IOs
> when the device can support 100K+.
Applied to 6.6/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-08-21 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 19:29 [PATCH 1/1] scsi: target: Fix write perf due to unneeded throttling Mike Christie
2023-08-21 21:21 ` Martin K. Petersen [this message]
2023-08-25 1:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ttss5byk.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox