From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Azeem Shaikh <azeemshaikh38@gmail.com>
Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>,
Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>,
azeems@google.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: bfa: Replace all non-returning strlcpy with strscpy
Date: Tue, 16 May 2023 21:38:56 -0400 [thread overview]
Message-ID: <yq1ttwbu47w.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230516013345.723623-1-azeemshaikh38@gmail.com> (Azeem Shaikh's message of "Tue, 16 May 2023 01:33:45 +0000")
Azeem,
> strlcpy() reads the entire source buffer first. This read may exceed
> the destination size limit. This is both inefficient and can lead to
> linear read overflows if a source string is not NUL-terminated [1]. In
> an effort to remove strlcpy() completely [2], replace strlcpy() here
> with strscpy(). No return values were used, so direct replacement is
> safe.
Applied to 6.5/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2023-05-17 1:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 1:33 [PATCH] scsi: bfa: Replace all non-returning strlcpy with strscpy Azeem Shaikh
2023-05-16 2:02 ` Azeem Shaikh
2023-05-16 18:15 ` Kees Cook
2023-05-17 1:38 ` Martin K. Petersen [this message]
2023-05-22 22:46 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1ttwbu47w.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=azeems@google.com \
--cc=azeemshaikh38@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sudarsana.kalluru@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox