From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dmitry Bogdanov <d.bogdanov@yadro.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux@yadro.com>, Roman Bolshakov <r.bolshakov@yadro.com>
Subject: Re: [PATCH v2] scsi: target: core: check SR field in REPORT LUNS
Date: Tue, 26 Jan 2021 23:36:52 -0500 [thread overview]
Message-ID: <yq1tur3knh1.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210120102700.5514-1-d.bogdanov@yadro.com> (Dmitry Bogdanov's message of "Wed, 20 Jan 2021 13:27:00 +0300")
Dmitry,
> + switch (sr) {
> + case SCSI_SELECT_WELLKNOWN:
> + case SCSI_SELECT_ADMINISTRATIVE:
> + case SCSI_SELECT_SUBSIDIARY:
> + /* report empty lun list */
> + goto out;
I'm a bit concerned about things inadvertently breaking if we return an
empty list for the well known LUNs.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2021-01-27 5:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 10:27 [PATCH v2] scsi: target: core: check SR field in REPORT LUNS Dmitry Bogdanov
2021-01-22 22:42 ` David Disseldorp
2021-01-26 9:13 ` Roman Bolshakov
2021-01-28 20:28 ` David Disseldorp
2021-01-27 4:36 ` Martin K. Petersen [this message]
2021-01-27 14:45 ` Dmitriy Bogdanov
2021-01-28 20:47 ` Bart Van Assche
2021-02-19 13:48 ` Dmitriy Bogdanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tur3knh1.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=r.bolshakov@yadro.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox