Re: [PATCH] scsi: lpfc: lpfc_nvmet.c: Fix Use plain integer as NULL pointer

James Smart
2019-10-24T18:15:38Z

On 10/23/2019 8:09 PM, Saurav Girepunje wrote:
> Replace assignment of 0 to pointer with NULL assignment.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index faa596f9e861..f6ebfe05224c 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -3364,7 +3364,7 @@ lpfc_nvmet_sol_fcp_issue_abort(struct lpfc_hba *phba,
> /* ABTS WQE must go to the same WQ as the WQE to be aborted */
> abts_wqeq->hba_wqidx = ctxp->wqeq->hba_wqidx;
> abts_wqeq->wqe_cmpl = lpfc_nvmet_sol_fcp_abort_cmp;
> - abts_wqeq->iocb_cmpl = 0;
> + abts_wqeq->iocb_cmpl = NULL;
> abts_wqeq->iocb_flag |= LPFC_IO_NVME;
> abts_wqeq->context2 = ctxp;
> abts_wqeq->vport = phba->pport;
> @@ -3499,7 +3499,7 @@ lpfc_nvmet_unsol_ls_issue_abort(struct lpfc_hba *phba,
>
> spin_lock_irqsave(&phba->hbalock, flags);
> abts_wqeq->wqe_cmpl = lpfc_nvmet_xmt_ls_abort_cmp;
> - abts_wqeq->iocb_cmpl = 0;
> + abts_wqeq->iocb_cmpl = NULL;
> abts_wqeq->iocb_flag |= LPFC_IO_NVME_LS;
> rc = lpfc_sli4_issue_wqe(phba, ctxp->hdwq, abts_wqeq);
> spin_unlock_irqrestore(&phba->hbalock, flags);

Thanks

Reviewed-by: James Smart <james.smart@broadcom.com>

-- james