From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Adaptec OEM Raid Solutions <aacraid@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ips: fix missing break in switch
Date: Wed, 17 Oct 2018 21:01:01 -0400 [thread overview]
Message-ID: <yq1tvlkkr02.fsf@oracle.com> (raw)
In-Reply-To: <alpine.LNX.2.21.1810171327290.8@nippy.intranet> (Finn Thain's message of "Wed, 17 Oct 2018 14:24:47 +1100 (AEDT)")
Finn,
>> See the case statements above for another fast exit scenario.
>>
>
> But that's an error path.
Look further down. Several other SCSI commands are completed as NOPs the
same way.
Also, I don't see how the case statement for TUR/INQUIRY would do
anything meaningful in terms of preparing a START STOP UNIT for the
firmware.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-10-18 1:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-16 9:12 [PATCH] scsi: ips: fix missing break in switch Gustavo A. R. Silva
2018-10-16 21:47 ` Martin K. Petersen
2018-10-16 22:27 ` Finn Thain
2018-10-17 1:19 ` Martin K. Petersen
2018-10-17 3:24 ` Finn Thain
2018-10-18 1:01 ` Martin K. Petersen [this message]
2018-10-18 2:37 ` Finn Thain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tvlkkr02.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=fthain@telegraphics.com.au \
--cc=gustavo@embeddedor.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox