* [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx
@ 2018-09-11 9:48 Masanari Iida
2018-09-26 4:21 ` Madhani, Himanshu
2018-09-27 23:49 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Masanari Iida @ 2018-09-11 9:48 UTC (permalink / raw)
To: qla2xxx-upstream, jejb, martin.petersen, linux-kernel,
himanshu.madhani, giridhar.malavali, linux-scsi
Cc: Masanari Iida
Default value of ql2xasynctmfenable for qla2xxx driver was
set to 1 in commit 043dc1d7e8501.
But comment in MODULE_PARAM_DESC was not modified.
Signed-off-by: Masanari Iida <standby24x7@gmail.com>
---
drivers/scsi/qla2xxx/qla_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 42b8f0d3e580..fe5404be73c5 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
module_param(ql2xasynctmfenable, int, S_IRUGO);
MODULE_PARM_DESC(ql2xasynctmfenable,
"Enables issue of TM IOCBs asynchronously via IOCB mechanism"
- "Default is 0 - Issue TM IOCBs via mailbox mechanism.");
+ "Default is 1 - Issue TM IOCBs via mailbox mechanism.");
int ql2xdontresethba;
module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx
2018-09-11 9:48 [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx Masanari Iida
@ 2018-09-26 4:21 ` Madhani, Himanshu
2018-09-27 23:49 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Madhani, Himanshu @ 2018-09-26 4:21 UTC (permalink / raw)
To: Masanari Iida
Cc: Dept-Eng QLA2xxx Upstream, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, linux-kernel@vger.kernel.org,
Malavali, Giridhar, linux-scsi@vger.kernel.org
> On Sep 11, 2018, at 2:48 AM, Masanari Iida <standby24x7@gmail.com> wrote:
>
> External Email
>
> Default value of ql2xasynctmfenable for qla2xxx driver was
> set to 1 in commit 043dc1d7e8501.
> But comment in MODULE_PARAM_DESC was not modified.
>
> Signed-off-by: Masanari Iida <standby24x7@gmail.com>
> ---
> drivers/scsi/qla2xxx/qla_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index 42b8f0d3e580..fe5404be73c5 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -204,7 +204,7 @@ int ql2xasynctmfenable = 1;
> module_param(ql2xasynctmfenable, int, S_IRUGO);
> MODULE_PARM_DESC(ql2xasynctmfenable,
> "Enables issue of TM IOCBs asynchronously via IOCB mechanism"
> - "Default is 0 - Issue TM IOCBs via mailbox mechanism.");
> + "Default is 1 - Issue TM IOCBs via mailbox mechanism.");
>
> int ql2xdontresethba;
> module_param(ql2xdontresethba, int, S_IRUGO|S_IWUSR);
> --
> 2.19.0
>
Thanks for the patch.
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
-Himanshu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx
2018-09-11 9:48 [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx Masanari Iida
2018-09-26 4:21 ` Madhani, Himanshu
@ 2018-09-27 23:49 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-09-27 23:49 UTC (permalink / raw)
To: Masanari Iida
Cc: qla2xxx-upstream, jejb, martin.petersen, linux-kernel,
himanshu.madhani, giridhar.malavali, linux-scsi
Masanari,
> Default value of ql2xasynctmfenable for qla2xxx driver was set to 1 in
> commit 043dc1d7e8501. But comment in MODULE_PARAM_DESC was not
> modified.
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-27 23:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-11 9:48 [PATCH] scsi: qla2xxx: Fix comment in MODULE_PARM_DESC in qla2xxx Masanari Iida
2018-09-26 4:21 ` Madhani, Himanshu
2018-09-27 23:49 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox