From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Yohan Joung <jyh429@gmail.com>
Cc: James.Bottomley@HansenPartnership.com,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
Yohan Joung <yohan.joung@sk.com>,
Damien Le Moal <dlemoal@kernel.org>
Subject: Re: [PATCH v1] scsi: Check the SPC version in sd_read_cpr
Date: Mon, 22 Jul 2024 20:49:39 -0400 [thread overview]
Message-ID: <yq1v80xc57l.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20240720150039.843-1-yohan.joung@sk.com> (Yohan Joung's message of "Sun, 21 Jul 2024 00:00:39 +0900")
Yohan,
> Add SPC version verification to avoid unnecessary inquiry command
Are you experiencing an actual error condition as a result of this
INQUIRY operation?
Devices often adopt new protocol features prior to the spec being
finalized. Therefore we generally use INQUIRY to discover capabilities
rather than relying on the reported spec compliance.
> + /* Support for CPR was defined in SPC-5. */
> + if (sdev->scsi_level < SCSI_SPC_5)
> + return;
> +
I'm OK with the change but I'll defer to Damien as to whether this is an
acceptable heuristic.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2024-07-23 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-20 15:00 [PATCH v1] scsi: Check the SPC version in sd_read_cpr Yohan Joung
2024-07-23 0:49 ` Martin K. Petersen [this message]
2024-07-23 0:57 ` Damien Le Moal
2024-07-23 2:08 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1v80xc57l.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dlemoal@kernel.org \
--cc=jyh429@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=yohan.joung@sk.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox