* [PATCH v1] ufs: core: bypass quick recovery if need force reset
@ 2024-07-12 9:45 peter.wang
2024-07-12 9:58 ` Bean Huo
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: peter.wang @ 2024-07-12 9:45 UTC (permalink / raw)
To: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb
Cc: wsd_upstream, linux-mediatek, peter.wang, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, tun-yu.yu, eddie.huang, naomi.chu,
chu.stanley
From: Peter Wang <peter.wang@mediatek.com>
If force_reset is true, bypass quick recovery.
This will shorten error recovery time.
Signed-off-by: Peter Wang <peter.wang@mediatek.com>
---
drivers/ufs/core/ufshcd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 46433ecf0c4d..357379ddd79a 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -6545,7 +6545,8 @@ static void ufshcd_err_handler(struct work_struct *work)
if (ufshcd_err_handling_should_stop(hba))
goto skip_err_handling;
- if (hba->dev_quirks & UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS) {
+ if ((hba->dev_quirks & UFS_DEVICE_QUIRK_RECOVERY_FROM_DL_NAC_ERRORS) &&
+ !hba->force_reset) {
bool ret;
spin_unlock_irqrestore(hba->host->host_lock, flags);
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] ufs: core: bypass quick recovery if need force reset
2024-07-12 9:45 [PATCH v1] ufs: core: bypass quick recovery if need force reset peter.wang
@ 2024-07-12 9:58 ` Bean Huo
2024-07-12 17:43 ` Bart Van Assche
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Bean Huo @ 2024-07-12 9:58 UTC (permalink / raw)
To: peter.wang, linux-scsi, martin.petersen, avri.altman, alim.akhtar,
jejb
Cc: wsd_upstream, linux-mediatek, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao, powen.kao, qilin.tan, lin.gui,
tun-yu.yu, eddie.huang, naomi.chu, chu.stanley
On Fri, 2024-07-12 at 17:45 +0800, peter.wang@mediatek.com wrote:
> From: Peter Wang <peter.wang@mediatek.com>
>
> If force_reset is true, bypass quick recovery.
> This will shorten error recovery time.
Reviewed-by: Bean Huo <beanhuo@micron.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] ufs: core: bypass quick recovery if need force reset
2024-07-12 9:45 [PATCH v1] ufs: core: bypass quick recovery if need force reset peter.wang
2024-07-12 9:58 ` Bean Huo
@ 2024-07-12 17:43 ` Bart Van Assche
2024-07-16 2:53 ` Martin K. Petersen
2024-07-23 1:23 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Bart Van Assche @ 2024-07-12 17:43 UTC (permalink / raw)
To: peter.wang, linux-scsi, martin.petersen, avri.altman, alim.akhtar,
jejb
Cc: wsd_upstream, linux-mediatek, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao, powen.kao, qilin.tan, lin.gui,
tun-yu.yu, eddie.huang, naomi.chu, chu.stanley
On 7/12/24 2:45 AM, peter.wang@mediatek.com wrote:
> If force_reset is true, bypass quick recovery.
> This will shorten error recovery time.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] ufs: core: bypass quick recovery if need force reset
2024-07-12 9:45 [PATCH v1] ufs: core: bypass quick recovery if need force reset peter.wang
2024-07-12 9:58 ` Bean Huo
2024-07-12 17:43 ` Bart Van Assche
@ 2024-07-16 2:53 ` Martin K. Petersen
2024-07-23 1:23 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2024-07-16 2:53 UTC (permalink / raw)
To: peter.wang
Cc: linux-scsi, martin.petersen, avri.altman, alim.akhtar, jejb,
wsd_upstream, linux-mediatek, chun-hung.wu, alice.chao, cc.chou,
chaotian.jing, jiajie.hao, powen.kao, qilin.tan, lin.gui,
tun-yu.yu, eddie.huang, naomi.chu, chu.stanley
> If force_reset is true, bypass quick recovery. This will shorten error
> recovery time.
Applied to 6.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] ufs: core: bypass quick recovery if need force reset
2024-07-12 9:45 [PATCH v1] ufs: core: bypass quick recovery if need force reset peter.wang
` (2 preceding siblings ...)
2024-07-16 2:53 ` Martin K. Petersen
@ 2024-07-23 1:23 ` Martin K. Petersen
3 siblings, 0 replies; 5+ messages in thread
From: Martin K. Petersen @ 2024-07-23 1:23 UTC (permalink / raw)
To: linux-scsi, avri.altman, alim.akhtar, jejb, peter.wang
Cc: Martin K . Petersen, wsd_upstream, linux-mediatek, chun-hung.wu,
alice.chao, cc.chou, chaotian.jing, jiajie.hao, powen.kao,
qilin.tan, lin.gui, tun-yu.yu, eddie.huang, naomi.chu,
chu.stanley
On Fri, 12 Jul 2024 17:45:06 +0800, peter.wang@mediatek.com wrote:
> If force_reset is true, bypass quick recovery.
> This will shorten error recovery time.
>
>
Applied to 6.11/scsi-queue, thanks!
[1/1] ufs: core: bypass quick recovery if need force reset
https://git.kernel.org/mkp/scsi/c/022587d8aec3
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-23 1:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-12 9:45 [PATCH v1] ufs: core: bypass quick recovery if need force reset peter.wang
2024-07-12 9:58 ` Bean Huo
2024-07-12 17:43 ` Bart Van Assche
2024-07-16 2:53 ` Martin K. Petersen
2024-07-23 1:23 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox