* [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st
@ 2022-07-30 12:37 Colin Ian King
2022-08-01 16:27 ` Khalid Aziz
2022-08-01 23:52 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin Ian King @ 2022-07-30 12:37 UTC (permalink / raw)
To: Khalid Aziz, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: kernel-janitors, linux-kernel
The variable bm_int_st is assigned a value but it is never read. The
variable and the assignment are redundant and can be removed.
Cleans up clang scan build warning:
drivers/scsi/FlashPoint.c:1726:7: warning: Although the value stored
to 'bm_int_st' is used in the enclosing expression, the value is never
actually read from 'bm_int_st' [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/scsi/FlashPoint.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
index 90253208a72f..3d9c56ac8224 100644
--- a/drivers/scsi/FlashPoint.c
+++ b/drivers/scsi/FlashPoint.c
@@ -1712,7 +1712,7 @@ static unsigned char FlashPoint_InterruptPending(void *pCurrCard)
static int FlashPoint_HandleInterrupt(void *pcard)
{
struct sccb *currSCCB;
- unsigned char thisCard, result, bm_status, bm_int_st;
+ unsigned char thisCard, result, bm_status;
unsigned short hp_int;
unsigned char i, target;
struct sccb_card *pCurrCard = pcard;
@@ -1723,7 +1723,7 @@ static int FlashPoint_HandleInterrupt(void *pcard)
MDISABLE_INT(ioport);
- if ((bm_int_st = RD_HARPOON(ioport + hp_int_status)) & EXT_STATUS_ON)
+ if (RD_HARPOON(ioport + hp_int_status) & EXT_STATUS_ON)
bm_status = RD_HARPOON(ioport + hp_ext_status) &
(unsigned char)BAD_EXT_STATUS;
else
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st
2022-07-30 12:37 [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st Colin Ian King
@ 2022-08-01 16:27 ` Khalid Aziz
2022-08-01 23:52 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Khalid Aziz @ 2022-08-01 16:27 UTC (permalink / raw)
To: Colin Ian King, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: kernel-janitors, linux-kernel
On 7/30/22 06:37, Colin Ian King wrote:
> The variable bm_int_st is assigned a value but it is never read. The
> variable and the assignment are redundant and can be removed.
>
> Cleans up clang scan build warning:
> drivers/scsi/FlashPoint.c:1726:7: warning: Although the value stored
> to 'bm_int_st' is used in the enclosing expression, the value is never
> actually read from 'bm_int_st' [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/scsi/FlashPoint.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Acked-by: Khalid Aziz <khalid@gonehiking.org>
>
> diff --git a/drivers/scsi/FlashPoint.c b/drivers/scsi/FlashPoint.c
> index 90253208a72f..3d9c56ac8224 100644
> --- a/drivers/scsi/FlashPoint.c
> +++ b/drivers/scsi/FlashPoint.c
> @@ -1712,7 +1712,7 @@ static unsigned char FlashPoint_InterruptPending(void *pCurrCard)
> static int FlashPoint_HandleInterrupt(void *pcard)
> {
> struct sccb *currSCCB;
> - unsigned char thisCard, result, bm_status, bm_int_st;
> + unsigned char thisCard, result, bm_status;
> unsigned short hp_int;
> unsigned char i, target;
> struct sccb_card *pCurrCard = pcard;
> @@ -1723,7 +1723,7 @@ static int FlashPoint_HandleInterrupt(void *pcard)
>
> MDISABLE_INT(ioport);
>
> - if ((bm_int_st = RD_HARPOON(ioport + hp_int_status)) & EXT_STATUS_ON)
> + if (RD_HARPOON(ioport + hp_int_status) & EXT_STATUS_ON)
> bm_status = RD_HARPOON(ioport + hp_ext_status) &
> (unsigned char)BAD_EXT_STATUS;
> else
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st
2022-07-30 12:37 [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st Colin Ian King
2022-08-01 16:27 ` Khalid Aziz
@ 2022-08-01 23:52 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2022-08-01 23:52 UTC (permalink / raw)
To: Colin Ian King
Cc: Khalid Aziz, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> The variable bm_int_st is assigned a value but it is never read. The
> variable and the assignment are redundant and can be removed.
Applied to 5.20/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-08-01 23:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-30 12:37 [PATCH] scsi: FlashPoint: remove redundant variable bm_int_st Colin Ian King
2022-08-01 16:27 ` Khalid Aziz
2022-08-01 23:52 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox