* [PATCH] scsi: bnx2fc: remove unneeded variable
@ 2019-03-29 3:24 Ding Xiang
2019-03-29 4:13 ` Manish Rangankar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Ding Xiang @ 2019-03-29 3:24 UTC (permalink / raw)
To: QLogic-Storage-Upstream, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel
"rc" is unneeded,just return SUCCESS
Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
---
drivers/scsi/bnx2fc/bnx2fc_io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
index bc9f2a2..8def63c 100644
--- a/drivers/scsi/bnx2fc/bnx2fc_io.c
+++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
@@ -1083,7 +1083,6 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd)
static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
{
struct bnx2fc_rport *tgt = io_req->tgt;
- int rc = SUCCESS;
unsigned int time_left;
io_req->wait_for_comp = 1;
@@ -1110,7 +1109,7 @@ static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
kref_put(&io_req->refcount, bnx2fc_cmd_release);
spin_lock_bh(&tgt->tgt_lock);
- return rc;
+ return SUCCESS;
}
/**
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] scsi: bnx2fc: remove unneeded variable
2019-03-29 3:24 [PATCH] scsi: bnx2fc: remove unneeded variable Ding Xiang
@ 2019-03-29 4:13 ` Manish Rangankar
2019-03-29 7:10 ` Mukesh Ojha
2019-03-29 14:17 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Manish Rangankar @ 2019-03-29 4:13 UTC (permalink / raw)
To: Ding Xiang, QLogic-Storage-Upstream@qlogic.com,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Ding Xiang <dingxiang@cmss.chinamobile.com>
> Sent: Friday, March 29, 2019 8:54 AM
> To: QLogic-Storage-Upstream@qlogic.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] scsi: bnx2fc: remove unneeded variable
>
> "rc" is unneeded,just return SUCCESS
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_io.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c
> b/drivers/scsi/bnx2fc/bnx2fc_io.c index bc9f2a2..8def63c 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1083,7 +1083,6 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd
> *sc_cmd) static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) {
> struct bnx2fc_rport *tgt = io_req->tgt;
> - int rc = SUCCESS;
> unsigned int time_left;
>
> io_req->wait_for_comp = 1;
> @@ -1110,7 +1109,7 @@ static int bnx2fc_abts_cleanup(struct
> bnx2fc_cmd *io_req)
> kref_put(&io_req->refcount, bnx2fc_cmd_release);
>
> spin_lock_bh(&tgt->tgt_lock);
> - return rc;
> + return SUCCESS;
> }
>
> /**
> --
> 1.9.1
>
Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: bnx2fc: remove unneeded variable
2019-03-29 3:24 [PATCH] scsi: bnx2fc: remove unneeded variable Ding Xiang
2019-03-29 4:13 ` Manish Rangankar
@ 2019-03-29 7:10 ` Mukesh Ojha
2019-03-29 14:17 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Mukesh Ojha @ 2019-03-29 7:10 UTC (permalink / raw)
To: Ding Xiang, QLogic-Storage-Upstream, jejb, martin.petersen
Cc: linux-scsi, linux-kernel
On 3/29/2019 8:54 AM, Ding Xiang wrote:
> "rc" is unneeded,just return SUCCESS
"rc variable is not needed in `bnx2fc_abts_cleanup`. Fix this by
removing it ."
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
>
> Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
> ---
> drivers/scsi/bnx2fc/bnx2fc_io.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c
> index bc9f2a2..8def63c 100644
> --- a/drivers/scsi/bnx2fc/bnx2fc_io.c
> +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c
> @@ -1083,7 +1083,6 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd)
> static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
> {
> struct bnx2fc_rport *tgt = io_req->tgt;
> - int rc = SUCCESS;
> unsigned int time_left;
>
> io_req->wait_for_comp = 1;
> @@ -1110,7 +1109,7 @@ static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req)
> kref_put(&io_req->refcount, bnx2fc_cmd_release);
>
> spin_lock_bh(&tgt->tgt_lock);
> - return rc;
> + return SUCCESS;
> }
>
> /**
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scsi: bnx2fc: remove unneeded variable
2019-03-29 3:24 [PATCH] scsi: bnx2fc: remove unneeded variable Ding Xiang
2019-03-29 4:13 ` Manish Rangankar
2019-03-29 7:10 ` Mukesh Ojha
@ 2019-03-29 14:17 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-03-29 14:17 UTC (permalink / raw)
To: Ding Xiang
Cc: QLogic-Storage-Upstream, jejb, martin.petersen, linux-scsi,
linux-kernel
Ding,
> "rc" is unneeded,just return SUCCESS
Applied to 5.2/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-29 14:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 3:24 [PATCH] scsi: bnx2fc: remove unneeded variable Ding Xiang
2019-03-29 4:13 ` Manish Rangankar
2019-03-29 7:10 ` Mukesh Ojha
2019-03-29 14:17 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).