* [PATCH] csi: libcxgbi: remove redundant check and close on csk
@ 2017-09-07 13:51 Colin King
2017-09-11 9:21 ` Varun Prakash
2017-09-16 1:45 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-09-07 13:51 UTC (permalink / raw)
To: James E . J . Bottomley, Martin K . Petersen, Varun Prakash,
linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
csk is always null on the error return path and so the non-null
check and call to cxgbi_sock_closed on csk is redundant and
can be removed.
Detected by: CoverityScan CID#114329 ("Logically dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/cxgbi/libcxgbi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
index 512c8f1ea5b0..da36c2de069e 100644
--- a/drivers/scsi/cxgbi/libcxgbi.c
+++ b/drivers/scsi/cxgbi/libcxgbi.c
@@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex)
rel_rt:
ip_rt_put(rt);
- if (csk)
- cxgbi_sock_closed(csk);
err_out:
return ERR_PTR(err);
}
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk
2017-09-07 13:51 [PATCH] csi: libcxgbi: remove redundant check and close on csk Colin King
@ 2017-09-11 9:21 ` Varun Prakash
2017-09-16 1:45 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Varun Prakash @ 2017-09-11 9:21 UTC (permalink / raw)
To: Colin King
Cc: James E . J . Bottomley, Martin K . Petersen, linux-scsi,
kernel-janitors, linux-kernel
On Thu, Sep 07, 2017 at 02:51:33PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> csk is always null on the error return path and so the non-null
> check and call to cxgbi_sock_closed on csk is redundant and
> can be removed.
>
> Detected by: CoverityScan CID#114329 ("Logically dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 512c8f1ea5b0..da36c2de069e 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -688,8 +688,6 @@ cxgbi_check_route(struct sockaddr *dst_addr, int ifindex)
>
> rel_rt:
> ip_rt_put(rt);
> - if (csk)
> - cxgbi_sock_closed(csk);
> err_out:
> return ERR_PTR(err);
> }
Acked-by: Varun Prakash <varun@chelsio.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk
2017-09-07 13:51 [PATCH] csi: libcxgbi: remove redundant check and close on csk Colin King
2017-09-11 9:21 ` Varun Prakash
@ 2017-09-16 1:45 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-09-16 1:45 UTC (permalink / raw)
To: Colin King
Cc: James E . J . Bottomley, Martin K . Petersen, Varun Prakash,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> csk is always null on the error return path and so the non-null check
> and call to cxgbi_sock_closed on csk is redundant and can be removed.
Applied to 4.15/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-16 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 13:51 [PATCH] csi: libcxgbi: remove redundant check and close on csk Colin King
2017-09-11 9:21 ` Varun Prakash
2017-09-16 1:45 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).