From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] csi: libcxgbi: remove redundant check and close on csk Date: Fri, 15 Sep 2017 21:45:15 -0400 Message-ID: References: <20170907135133.16636-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20170907135133.16636-1-colin.king@canonical.com> (Colin King's message of "Thu, 7 Sep 2017 14:51:33 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Colin King Cc: "James E . J . Bottomley" , "Martin K . Petersen" , Varun Prakash , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Colin, > csk is always null on the error return path and so the non-null check > and call to cxgbi_sock_closed on csk is redundant and can be removed. Applied to 4.15/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering