From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: weiping zhang <zhangweiping@didichuxing.com>
Cc: jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi-sysfs: correct errno for host_reset
Date: Wed, 16 Aug 2017 21:11:03 -0400 [thread overview]
Message-ID: <yq1valnngm0.fsf@oracle.com> (raw)
In-Reply-To: <20170810175212.GA19528@localhost.didichuxing.com> (weiping zhang's message of "Fri, 11 Aug 2017 01:52:17 +0800")
weiping,
> if scsi_host_template->host_reset is NULL, when user "echo adapter >
> /sys/class/scsi_host/hostx/host_reset", -EINVAL will return even
> string compare successfully. It make user confuse.
>
> change to:
> -EINVAL if string not match "adapter" / "firmware";
> -EOPNOTSUPP if string match but not implement ->host_reset.
Applied to 4.14/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-08-17 1:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-10 17:52 [PATCH] scsi-sysfs: correct errno for host_reset weiping zhang
2017-08-14 12:30 ` weiping zhang
2017-08-17 1:11 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1valnngm0.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=zhangweiping@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).