From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Jack Wang <jinpu.wang@profitbricks.com>,
lindar_liu@usish.com,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
pmchba@pmcs.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap()
Date: Thu, 14 Apr 2016 22:38:16 -0400 [thread overview]
Message-ID: <yq1vb3jsijr.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1460582816-12703-1-git-send-email-ddaney.cavm@gmail.com> (David Daney's message of "Wed, 13 Apr 2016 14:26:56 -0700")
>>>>> "David" == David Daney <ddaney.cavm@gmail.com> writes:
David> It is unclear what the original intent of the masking was, but it
David> is clearly incorrect to truncate a physical address before
David> calling ioremap(). On systems where there are valid physical
David> address bits above bit-31 (arm64 for example) the result is an
David> eventual OOPs when initializing the driver.
David> Remove the bogus code to fix it.
Applied to 4.7/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2016-04-15 2:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 21:26 [PATCH] pm80xx: Remove bogus address masking in pm8001_ioremap() David Daney
2016-04-14 12:22 ` Jinpu Wang
2016-04-15 2:38 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vb3jsijr.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=jinpu.wang@profitbricks.com \
--cc=lindar_liu@usish.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pmchba@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).