From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tom Yan <tom.ty89@gmail.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] sd: fix lbprz discard granularity as expected
Date: Fri, 11 Mar 2016 16:41:54 -0500 [thread overview]
Message-ID: <yq1vb4sk7z1.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <CAGnHSEn-5=nzryFJ6wZU+f82kHqf6LJLfi6LbWCyq+qd+E1TWQ@mail.gmail.com> (Tom Yan's message of "Fri, 11 Mar 2016 22:55:30 +0800")
>>>>> "Tom" == Tom Yan <tom.ty89@gmail.com> writes:
Tom,
Tom> Would min_not_zero() be more proper than max()?
That would effectively set discard_granularity to physical_block_size
regardless of whether unmap_granularity was provided or not.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2016-03-11 21:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 8:16 [PATCH 1/1] sd: fix lbprz discard granularity as expected tom.ty89
2016-03-10 9:15 ` Tom Yan
2016-03-11 2:16 ` Martin K. Petersen
2016-03-11 3:53 ` Tom Yan
2016-03-11 12:37 ` Martin K. Petersen
2016-03-11 14:55 ` Tom Yan
2016-03-11 21:41 ` Martin K. Petersen [this message]
2016-03-12 5:37 ` Tom Yan
2016-03-12 5:43 ` Tom Yan
2016-03-14 20:07 ` Martin K. Petersen
2016-03-11 2:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1vb4sk7z1.fsf@sermon.lab.mkp.net \
--to=martin.petersen@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox