From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null) Date: Mon, 23 Jun 2014 15:37:03 -0400 Message-ID: References: <53A28B21.7070500@profihost.ag> <20140620155321.GA24389@soda.linbit> <20140620182956.GB24389@soda.linbit> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:48676 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755945AbaFWThg (ORCPT ); Mon, 23 Jun 2014 15:37:36 -0400 In-Reply-To: <20140620182956.GB24389@soda.linbit> (Lars Ellenberg's message of "Fri, 20 Jun 2014 20:29:56 +0200") Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Lars Ellenberg Cc: "Martin K. Petersen" , Stefan Priebe - Profihost AG , NeilBrown , linux-raid@vger.kernel.org, linux-scsi , JBottomley@parallels.com, Jens Axboe , konrad.wilk@oracle.com, elder@linaro.org, Josh Durgin , Greg KH >>>>> "Lars" == Lars Ellenberg writes: Lars, Thanks for fixing this. I'd still like to see you use the lib call instead like you do for zeroout. I have some patches in the pipeline for multi-range discard support and things are going to break for drbd if you manually roll bios. Lars> linux upstream DRBD also does blk_queue_max_write_same_sectors(q, Lars> 0) and blk_queue_max_discard_sectors(q, DRBD_MAX_DISCARD_SECTORS) Great! -- Martin K. Petersen Oracle Linux Engineering