From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Tom Rix <trix@redhat.com>
Cc: brking@us.ibm.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, john.g.garry@oracle.com,
dlemoal@kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: ipr: remove several unused variables
Date: Mon, 24 Apr 2023 23:12:52 -0400 [thread overview]
Message-ID: <yq1wn20k638.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230420125035.3888188-1-trix@redhat.com> (Tom Rix's message of "Thu, 20 Apr 2023 08:50:35 -0400")
Tom,
> gcc with W=1 reports
> drivers/scsi/ipr.c: In function ‘ipr_init_res_entry’:
> drivers/scsi/ipr.c:1104:22: error: variable ‘proto’
> set but not used [-Werror=unused-but-set-variable]
> 1104 | unsigned int proto;
> | ^~~~~
> drivers/scsi/ipr.c: In function ‘ipr_update_res_entry’:
> drivers/scsi/ipr.c:1261:22: error: variable ‘proto’
> set but not used [-Werror=unused-but-set-variable]
> 1261 | unsigned int proto;
> | ^~~~~
> drivers/scsi/ipr.c: In function ‘ipr_change_queue_depth’:
> drivers/scsi/ipr.c:4417:36: error: variable ‘res’
> set but not used [-Werror=unused-but-set-variable]
> 4417 | struct ipr_resource_entry *res;
> | ^~~
>
> These variables are not used, so remove them.
> The lock around res is not needed so remove that.
> Which makes ioa_cfg and lock_flags unneeded so remove them.
Applied to 6.4/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-04-25 3:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-20 12:50 [PATCH] scsi: ipr: remove several unused variables Tom Rix
2023-04-20 18:58 ` Brian King
2023-04-25 3:12 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wn20k638.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=brking@us.ibm.com \
--cc=dlemoal@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=john.g.garry@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox