From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] scsi: Improves scsi_vpd_inquiry() checks
Date: Fri, 24 Mar 2023 21:20:50 -0400 [thread overview]
Message-ID: <yq1wn35hbl3.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20230322022211.116327-1-damien.lemoal@opensource.wdc.com> (Damien Le Moal's message of "Wed, 22 Mar 2023 11:22:11 +0900")
Damien,
> Some USB-SATA adapters have a broken behavior when a non supported VPD
> page is probed: depending on the VPD page number, a 4 byte header with a
> valid VPD page number but with a 0 lenghth is returned. Currently,
> scsi_vpd_inquiry() only checks that the page number is valid to
> determine if the page is supported, which results in VPD page users
> receiving only the 4 B header for the non existent page. This error
> manifests itself very often with page 0xb9 for the concurrent
> Positioning Ranges detection done by sd_read_cpr(), resulting in the
> error message:
Applied to 6.3/scsi-fixes, thanks!
[1/1] scsi: core: Improve scsi_vpd_inquiry() checks
https://git.kernel.org/mkp/scsi/c/f0aa59a33d2a
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-03-25 1:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 2:22 [PATCH] scsi: Improves scsi_vpd_inquiry() checks Damien Le Moal
2023-03-24 13:53 ` Benjamin Block
2023-03-25 1:20 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wn35hbl3.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox