From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Viswas G <Viswas.G@microchip.com.com>
Cc: <linux-scsi@vger.kernel.org>,
<Vasanthalakshmi.Tharmarajan@microchip.com>,
Ruksar Devadi <Ruksar.devadi@microchip.com>,
<Viswas.G@microchip.com>, "peter chang" <dpf@google.com>,
<vishakhavc@google.com>, <radha@google.com>,
<akshatzen@google.com>
Subject: Re: [PATCH 1/4] pm80xx: make mpi_build_cmd locking consistent
Date: Mon, 26 Oct 2020 20:41:59 -0400 [thread overview]
Message-ID: <yq1wnzc5x5s.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20201012052415.18963-2-Viswas.G@microchip.com.com> (Viswas G.'s message of "Mon, 12 Oct 2020 10:54:12 +0530")
Hi Viswas,
Your patch descriptions need some work. See
Documentation/process/submitting-patches.rst
Specifically the section named "Describe your changes".
> the missing task completions appear to be
Which missing completions are these?
[...]
> if a sata request issues from cpu zero when a management request
> issues, then there is some 'tearing' and the issue queue is sort of
> broken and we lose track of issues.
Too vague for a problem description.
> disabling interrupts may be overkill because there may not be cases
> where we're using this from interrupt context (the interrupt path
> has a different per-queue lock).
No clear description of what the fix is.
Please reword your patch descriptions so it is clear to the reviewer
what the problem is and how it is being addressed in the code changes
that follow.
Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2020-10-27 0:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-12 5:24 [PATCH 0/4] pm80xx updates Viswas G
2020-10-12 5:24 ` [PATCH 1/4] pm80xx: make mpi_build_cmd locking consistent Viswas G
2020-10-27 0:41 ` Martin K. Petersen [this message]
2020-10-12 5:24 ` [PATCH 2/4] pm80xx: make running_req atomic Viswas G
2020-10-12 5:24 ` [PATCH 3/4] pm80xx: Avoid busywait in FW ready check Viswas G
2020-10-12 5:24 ` [PATCH 4/4] pm80xx: make pm8001_mpi_set_nvmd_resp free of race condition Viswas G
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wnzc5x5s.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=Ruksar.devadi@microchip.com \
--cc=Vasanthalakshmi.Tharmarajan@microchip.com \
--cc=Viswas.G@microchip.com \
--cc=Viswas.G@microchip.com.com \
--cc=akshatzen@google.com \
--cc=dpf@google.com \
--cc=linux-scsi@vger.kernel.org \
--cc=radha@google.com \
--cc=vishakhavc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox