From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E052AC32792 for ; Tue, 1 Oct 2019 02:55:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B763620842 for ; Tue, 1 Oct 2019 02:55:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="UwpO9R7w" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732167AbfJACzC (ORCPT ); Mon, 30 Sep 2019 22:55:02 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:48784 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727669AbfJACzC (ORCPT ); Mon, 30 Sep 2019 22:55:02 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x912sukG122995; Tue, 1 Oct 2019 02:54:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=oUxaSTBomihR1YtYfZj38KE2aeIXjpEiC37YHJQvq0A=; b=UwpO9R7waAYCH40YOILclnjcEGr5PHJqDNmWEEsmlXa1txsV5AIU53oF4uHonjKw1c6A liAZVmkz9r+DOp8SmWfjXwCf2tjqgDGL/GpKu2a0L/k9xYsnpcZ+EPy5z8MPK/gTzNeE /uNA7Bob74Zfrh9WD3/F82wOw/P+A2drAH3AyRwLe4v0hskJ3UnX/ZvMFtw4IwHLaCW7 VqS6b0AId7tQpK1NjOh6mHtpzEk8QpU/N9MerJWJhYnMiy1aDIG6LwUvAGoHLB6AAapQ 2XfeMCwE5aT6BXhcDaKdb6EmB60CghKSnafIxdYoBk8+D1DzQNhvQM7iwvwWH9Bbx3Ow RQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2130.oracle.com with ESMTP id 2v9xxujvy6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Oct 2019 02:54:56 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x912mw7x026439; Tue, 1 Oct 2019 02:54:55 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3030.oracle.com with ESMTP id 2vbmpxh868-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Oct 2019 02:54:55 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x912sp8D028073; Tue, 1 Oct 2019 02:54:54 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 30 Sep 2019 19:54:51 -0700 To: Navid Emamdoost Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: bfa: release allocated memory in case of error From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190910234417.22151-1-navid.emamdoost@gmail.com> Date: Mon, 30 Sep 2019 22:54:48 -0400 In-Reply-To: <20190910234417.22151-1-navid.emamdoost@gmail.com> (Navid Emamdoost's message of "Tue, 10 Sep 2019 18:44:15 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9396 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=931 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010028 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9396 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1910010029 Sender: linux-scsi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Navid, > In bfad_im_get_stats if bfa_port_get_stats fails, allocated memory > needs to be released. Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering