From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Dave Carroll <david.carroll@microsemi.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
dl-esc-Aacraid Linux Driver <aacraid@microsemi.com>,
Mahesh Rajashekhara <mahesh.rajashekhara@microsemi.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: aacraid: Off by one NUL terminator
Date: Thu, 27 Jul 2017 12:30:42 -0400 [thread overview]
Message-ID: <yq1wp6tvo3x.fsf@oracle.com> (raw)
In-Reply-To: <423FD6710FB8FB4F8728F93591889F9A5307D0DC@avsrvexchmbx2.microsemi.net> (Dave Carroll's message of "Thu, 27 Jul 2017 16:26:17 +0000")
Dave,
> The issue is that we are making an inquiry response from
> container/RAID info. We could also have included a "pad" byte to
> terminate the string, as the fib data is 512 bytes. My assumption is
> that somehow back in the day, someone managed to get odd characters
> into the name.
>
> Terminating the string early would truncate the name ...
So what do you propose as a fix?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-07-27 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-25 19:49 [PATCH 1/2] scsi: aacraid: reading out of bounds Dan Carpenter
2017-07-25 19:51 ` [PATCH 2/2] scsi: aacraid: Off by one NUL terminator Dan Carpenter
2017-07-25 21:19 ` Bart Van Assche
2017-07-27 3:08 ` Martin K. Petersen
2017-07-27 9:00 ` Dan Carpenter
2017-07-27 12:55 ` Martin K. Petersen
2017-07-27 16:26 ` Dave Carroll
2017-07-27 16:30 ` Martin K. Petersen [this message]
2017-07-27 16:51 ` Dave Carroll
2017-07-27 2:10 ` [PATCH 1/2] scsi: aacraid: reading out of bounds Martin K. Petersen
2017-07-27 16:12 ` Dave Carroll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1wp6tvo3x.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=aacraid@microsemi.com \
--cc=dan.carpenter@oracle.com \
--cc=david.carroll@microsemi.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mahesh.rajashekhara@microsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox