[PATCH] Remove the definition of VLC_SA_RECEIVE_CREDENTIAL

[PATCH] Remove the definition of VLC_SA_RECEIVE_CREDENTIAL

[Bart Van Assche]

The symbolic name VLC_SA_RECEIVE_CREDENTIAL is not used anywhere
in the kernel. Additionally, since SPC 5 the RECEIVE CREDENTIAL
command is obsolete. The VLC_SA_RECEIVE_CREDENTIAL definition is
misleading since it occurs outside the list of other variable
length CDB service action codes (READ_32, WRITE_32, ...). Hence
remove this definition.

References: commit e9ccc998b70f ("[SCSI] Add missing SPC-4 CDB and MAINTENANCE_[IN,OUT] service action definitions")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>
---
 include/scsi/scsi_proto.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/scsi/scsi_proto.h b/include/scsi/scsi_proto.h
index ce78ec8e367d..78215fd6cdfd 100644
--- a/include/scsi/scsi_proto.h
+++ b/include/scsi/scsi_proto.h
@@ -125,9 +125,6 @@
 #define	SAI_READ_CAPACITY_16  0x10
 #define SAI_GET_LBA_STATUS    0x12
 #define SAI_REPORT_REFERRALS  0x13
-/* values for VARIABLE_LENGTH_CMD service action codes
- * see spc4r17 Section D.3.5, table D.7 and D.8 */
-#define VLC_SA_RECEIVE_CREDENTIAL 0x1800
 /* values for maintenance in */
 #define MI_REPORT_IDENTIFYING_INFORMATION 0x05
 #define MI_REPORT_TARGET_PGS  0x0a
-- 
2.13.1

Re: [PATCH] Remove the definition of VLC_SA_RECEIVE_CREDENTIAL

[Christoph Hellwig]

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Re: [PATCH] Remove the definition of VLC_SA_RECEIVE_CREDENTIAL

[Johannes Thumshirn]

On Fri, Jun 23, 2017 at 10:32:39AM -0700, Bart Van Assche wrote:
> The symbolic name VLC_SA_RECEIVE_CREDENTIAL is not used anywhere
> in the kernel. Additionally, since SPC 5 the RECEIVE CREDENTIAL
> command is obsolete. The VLC_SA_RECEIVE_CREDENTIAL definition is
> misleading since it occurs outside the list of other variable
> length CDB service action codes (READ_32, WRITE_32, ...). Hence
> remove this definition.
> 
> References: commit e9ccc998b70f ("[SCSI] Add missing SPC-4 CDB and MAINTENANCE_[IN,OUT] service action definitions")
> Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Hannes Reinecke <hare@suse.com>
> Cc: Johannes Thumshirn <jthumshirn@suse.de>
> ---

Thanks Bart,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH] Remove the definition of VLC_SA_RECEIVE_CREDENTIAL

[Martin K. Petersen]

Bart,

> The symbolic name VLC_SA_RECEIVE_CREDENTIAL is not used anywhere in
> the kernel. Additionally, since SPC 5 the RECEIVE CREDENTIAL command
> is obsolete. The VLC_SA_RECEIVE_CREDENTIAL definition is misleading
> since it occurs outside the list of other variable length CDB service
> action codes (READ_32, WRITE_32, ...). Hence remove this definition.

Applied to 4.13/scsi-queue.

-- 
Martin K. Petersen	Oracle Linux Engineering