* [patch] scsi_dh_emc: return success in clariion_std_inquiry()
@ 2017-02-21 18:46 Dan Carpenter
2017-02-22 6:47 ` Hannes Reinecke
2017-02-23 0:28 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2017-02-21 18:46 UTC (permalink / raw)
To: James E.J. Bottomley, Hannes Reinecke
Cc: Martin K. Petersen, Jens Axboe, Johannes Thumshirn,
Shaun Tancheff, linux-scsi, kernel-janitors
We accidentally return an uninitialized variable on success.
Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/device_handler/scsi_dh_emc.c
index 4a7679f6c73d..f1578832ec7a 100644
--- a/drivers/scsi/device_handler/scsi_dh_emc.c
+++ b/drivers/scsi/device_handler/scsi_dh_emc.c
@@ -358,7 +358,7 @@ static int clariion_prep_fn(struct scsi_device *sdev, struct request *req)
static int clariion_std_inquiry(struct scsi_device *sdev,
struct clariion_dh_data *csdev)
{
- int err;
+ int err = SCSI_DH_OK;
char *sp_model;
sp_model = parse_sp_model(sdev, sdev->inquiry);
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [patch] scsi_dh_emc: return success in clariion_std_inquiry()
2017-02-21 18:46 [patch] scsi_dh_emc: return success in clariion_std_inquiry() Dan Carpenter
@ 2017-02-22 6:47 ` Hannes Reinecke
2017-02-23 0:28 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Hannes Reinecke @ 2017-02-22 6:47 UTC (permalink / raw)
To: Dan Carpenter, James E.J. Bottomley
Cc: Martin K. Petersen, Jens Axboe, Johannes Thumshirn,
Shaun Tancheff, linux-scsi, kernel-janitors
On 02/21/2017 07:46 PM, Dan Carpenter wrote:
> We accidentally return an uninitialized variable on success.
>
> Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_emc.c b/drivers/scsi/device_handler/scsi_dh_emc.c
> index 4a7679f6c73d..f1578832ec7a 100644
> --- a/drivers/scsi/device_handler/scsi_dh_emc.c
> +++ b/drivers/scsi/device_handler/scsi_dh_emc.c
> @@ -358,7 +358,7 @@ static int clariion_prep_fn(struct scsi_device *sdev, struct request *req)
> static int clariion_std_inquiry(struct scsi_device *sdev,
> struct clariion_dh_data *csdev)
> {
> - int err;
> + int err = SCSI_DH_OK;
> char *sp_model;
>
> sp_model = parse_sp_model(sdev, sdev->inquiry);
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [patch] scsi_dh_emc: return success in clariion_std_inquiry()
2017-02-21 18:46 [patch] scsi_dh_emc: return success in clariion_std_inquiry() Dan Carpenter
2017-02-22 6:47 ` Hannes Reinecke
@ 2017-02-23 0:28 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-02-23 0:28 UTC (permalink / raw)
To: Dan Carpenter
Cc: James E.J. Bottomley, Hannes Reinecke, Martin K. Petersen,
Jens Axboe, Johannes Thumshirn, Shaun Tancheff, linux-scsi,
kernel-janitors
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan,
Dan> We accidentally return an uninitialized variable on success.
Applied to 4.11/scsi-fixes.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-23 0:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-21 18:46 [patch] scsi_dh_emc: return success in clariion_std_inquiry() Dan Carpenter
2017-02-22 6:47 ` Hannes Reinecke
2017-02-23 0:28 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox