* [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA
@ 2016-01-15 13:39 Geert Uytterhoeven
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-01-15 13:39 UTC (permalink / raw)
To: John Garry, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_set_mask" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_destroy" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_free_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_free" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_alloc_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_supported" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
ERROR: "dma_pool_create" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
Add a dependency on HAS_DMA to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/scsi/hisi_sas/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
index 37a0c7156087905b..2c05021636a5fea6 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -1,5 +1,6 @@
config SCSI_HISI_SAS
tristate "HiSilicon SAS"
+ depends on HAS_DMA
select SCSI_SAS_LIBSAS
select BLK_DEV_INTEGRITY
help
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64
2016-01-15 13:39 [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA Geert Uytterhoeven
@ 2016-01-15 13:39 ` Geert Uytterhoeven
2016-01-19 9:56 ` John Garry
2016-01-20 0:25 ` Martin K. Petersen
2016-01-19 9:47 ` [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA John Garry
2016-01-20 0:24 ` Martin K. Petersen
2 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2016-01-15 13:39 UTC (permalink / raw)
To: John Garry, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel, Geert Uytterhoeven
The HiSilicon SAS HBA is available in HiSilicon arm64 SoCs only.
Restrict it to arm64, unless compile-testing.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/scsi/hisi_sas/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
index 2c05021636a5fea6..b67661836c9fa26f 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -1,6 +1,7 @@
config SCSI_HISI_SAS
tristate "HiSilicon SAS"
depends on HAS_DMA
+ depends on ARM64 || COMPILE_TEST
select SCSI_SAS_LIBSAS
select BLK_DEV_INTEGRITY
help
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
@ 2016-01-19 9:56 ` John Garry
2016-01-20 0:25 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: John Garry @ 2016-01-19 9:56 UTC (permalink / raw)
To: Geert Uytterhoeven, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 15/01/2016 13:39, Geert Uytterhoeven wrote:
> The HiSilicon SAS HBA is available in HiSilicon arm64 SoCs only.
> Restrict it to arm64, unless compile-testing.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 2c05021636a5fea6..b67661836c9fa26f 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -1,6 +1,7 @@
> config SCSI_HISI_SAS
> tristate "HiSilicon SAS"
> depends on HAS_DMA
> + depends on ARM64 || COMPILE_TEST
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> help
>
Reviewed-by: John Garry <john.garry@huawei.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
2016-01-19 9:56 ` John Garry
@ 2016-01-20 0:25 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2016-01-20 0:25 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: John Garry, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
>>>>> "Geert" == Geert Uytterhoeven <geert@linux-m68k.org> writes:
Geert> The HiSilicon SAS HBA is available in HiSilicon arm64 SoCs only.
Geert> Restrict it to arm64, unless compile-testing.
Applied to 4.5/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA
2016-01-15 13:39 [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA Geert Uytterhoeven
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
@ 2016-01-19 9:47 ` John Garry
2016-01-20 0:24 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: John Garry @ 2016-01-19 9:47 UTC (permalink / raw)
To: Geert Uytterhoeven, James E.J. Bottomley, Martin K. Petersen
Cc: linux-scsi, linux-kernel
On 15/01/2016 13:39, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined!
> ERROR: "dma_unmap_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_set_mask" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_map_sg" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_destroy" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_free_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_free" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_alloc_coherent" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_supported" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
> ERROR: "dma_pool_create" [drivers/scsi/hisi_sas/hisi_sas_main.ko] undefined!
>
> Add a dependency on HAS_DMA to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 37a0c7156087905b..2c05021636a5fea6 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -1,5 +1,6 @@
> config SCSI_HISI_SAS
> tristate "HiSilicon SAS"
> + depends on HAS_DMA
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> help
>
Reviewed-by: John Garry <john.garry@huawei.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA
2016-01-15 13:39 [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA Geert Uytterhoeven
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
2016-01-19 9:47 ` [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA John Garry
@ 2016-01-20 0:24 ` Martin K. Petersen
2 siblings, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2016-01-20 0:24 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: John Garry, James E.J. Bottomley, Martin K. Petersen, linux-scsi,
linux-kernel
>>>>> "Geert" == Geert Uytterhoeven <geert@linux-m68k.org> writes:
Geert> If NO_DMA=y: ERROR: "dma_map_sg"
Geert> [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko] undefined! ERROR:
Geert> "dma_pool_alloc" [drivers/scsi/hisi_sas/hisi_sas_v1_hw.ko]
Geert> undefined! ERROR: "dma_unmap_sg"
Geert> Add a dependency on HAS_DMA to fix this.
Applied to 4.5/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-20 1:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-15 13:39 [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA Geert Uytterhoeven
2016-01-15 13:39 ` [PATCH 2/2] hisi_sas: Restrict SCSI_HISI_SAS to arm64 Geert Uytterhoeven
2016-01-19 9:56 ` John Garry
2016-01-20 0:25 ` Martin K. Petersen
2016-01-19 9:47 ` [PATCH 1/2] hisi_sas: SCSI_HISI_SAS should depend on HAS_DMA John Garry
2016-01-20 0:24 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox