From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Smart <james.smart@broadcom.com>,
Colin Ian King <colin.i.king@gmail.com>
Cc: Dick Kennedy <dick.kennedy@broadcom.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: lpfc: remove redundant pointer lp
Date: Mon, 07 Nov 2022 22:46:56 -0500 [thread overview]
Message-ID: <yq1y1smi03t.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20221101115657.48267-1-colin.i.king@gmail.com> (Colin Ian King's message of "Tue, 1 Nov 2022 11:56:57 +0000")
Colin,
> Pointer lp is being initialized and incremented but the result
> is never read. The pointer is redundant and can be removed.
> @@ -9173,14 +9173,11 @@ lpfc_els_rcv_farpr(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> struct lpfc_nodelist *ndlp)
Looks like this function has been dubious for a long time. From a quick
glance it doesn't appear to have done anything useful with those
variable assignments since back in the 4.x days.
James, please have a look.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2022-11-08 3:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-01 11:56 [PATCH] scsi: lpfc: remove redundant pointer lp Colin Ian King
2022-11-01 14:49 ` kernel test robot
2022-11-08 3:46 ` Martin K. Petersen [this message]
2022-11-15 7:07 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y1smi03t.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=colin.i.king@gmail.com \
--cc=dick.kennedy@broadcom.com \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox