From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: James Smart <jsmart2021@gmail.com>
Cc: linux-scsi@vger.kernel.org, ram.vegesna@broadcom.com,
dan.carpenter@oracle.com
Subject: Re: [PATCH] elx: efct: fix pointer error checking in debugfs init
Date: Fri, 18 Jun 2021 22:41:13 -0400 [thread overview]
Message-ID: <yq1y2b6wp8c.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20210618233004.83769-1-jsmart2021@gmail.com> (James Smart's message of "Fri, 18 Jun 2021 16:30:04 -0700")
James,
> debugfs_create_xxx routines, which return pointers, are being checked
> for error by looking for NULL values. The routines may return
> pointer-munged -Exxx codes, so they should be using IS_ERR() to adapt.
Applied to 5.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2021-06-19 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 23:30 [PATCH] elx: efct: fix pointer error checking in debugfs init James Smart
2021-06-19 2:41 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y2b6wp8c.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ram.vegesna@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox