From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH 2/4] lpfc: reduce stack size with CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE Date: Thu, 11 Jul 2019 20:47:03 -0400 Message-ID: References: <20190628123819.2785504-1-arnd@arndb.de> <20190628123819.2785504-2-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190628123819.2785504-2-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 28 Jun 2019 14:37:47 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Arnd Bergmann Cc: James Morris , devel@driverdev.osuosl.org, Hannes Reinecke , linux-scsi@vger.kernel.org, James Smart , lvs-devel@vger.kernel.org, Julian Anastasov , coreteam@netfilter.org, Pablo Neira Ayuso , Wensong Zhang , Dick Kennedy , Kees Cook , "James E.J. Bottomley" , Silvio Cesare , Simon Horman , Florian Schilhabel , "Martin K. Petersen" , Ard Biesheuvel , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Willy Tarreau , netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, "David S . Miller" , Larr List-Id: linux-scsi@vger.kernel.org Arnd, > The lpfc_debug_dump_all_queues() function repeatedly calls into > lpfc_debug_dump_qe(), which has a temporary 128 byte buffer. This was > fine before the introduction of CONFIG_GCC_PLUGIN_STRUCTLEAK_VERBOSE > because each instance could occupy the same stack slot. However, now > they each get their own copy, which leads to a huge increase in stack > usage as seen from the compiler warning: Applied to 5.3/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering