* [PATCH 1/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe
@ 2018-04-10 12:37 Jia-Ju Bai
2018-04-20 22:38 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Jia-Ju Bai @ 2018-04-10 12:37 UTC (permalink / raw)
To: Kai.Makisara, jejb, martin.petersen; +Cc: linux-scsi, linux-kernel, Jia-Ju Bai
st_probe() is never called in atomic context.
st_probe() is only set as ".probe" in struct scsi_driver.
Despite never getting called from atomic context,
st_probe() calls kzalloc() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/scsi/st.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/st.c b/drivers/scsi/st.c
index 94e402e..1da42f3 100644
--- a/drivers/scsi/st.c
+++ b/drivers/scsi/st.c
@@ -4290,7 +4290,7 @@ static int st_probe(struct device *dev)
goto out_buffer_free;
}
- tpnt = kzalloc(sizeof(struct scsi_tape), GFP_ATOMIC);
+ tpnt = kzalloc(sizeof(struct scsi_tape), GFP_KERNEL);
if (tpnt == NULL) {
sdev_printk(KERN_ERR, SDp,
"st: Can't allocate device descriptor.\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe
2018-04-10 12:37 [PATCH 1/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe Jia-Ju Bai
@ 2018-04-20 22:38 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2018-04-20 22:38 UTC (permalink / raw)
To: Jia-Ju Bai; +Cc: Kai.Makisara, jejb, martin.petersen, linux-scsi, linux-kernel
Jia-Ju,
> st_probe() is never called in atomic context.
Applied patches 1 and 2 to 4.18/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-20 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-10 12:37 [PATCH 1/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe Jia-Ju Bai
2018-04-20 22:38 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).