From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 0/4] ses: simple subenclosure support
Date: Wed, 16 Aug 2017 20:28:44 -0400 [thread overview]
Message-ID: <yq1y3qjox4z.fsf@oracle.com> (raw)
In-Reply-To: <1502785303-41870-1-git-send-email-hare@suse.de> (Hannes Reinecke's message of "Tue, 15 Aug 2017 10:21:39 +0200")
Hannes,
> some arrays (most notably 3Par) only support simple subenclosures.
> Sadly our ses implementation doesn't handle this properly, so we're
> greeted with error messages like:
>
> scsi 1:0:0:254: Wrong diagnostic page; asked for 2 got 0
> scsi 1:0:0:254: Failed to get diagnostic page 0xffffffea
> scsi 1:0:0:254: Failed to bind enclosure -19
> ses 1:0:0:254: Attached Enclosure device
>
> This patchset fixes up our ses implementation to work properly
> with simple subenclosures.
Looks OK to me. Applied to 4.14/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2017-08-17 0:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 8:21 [PATCH 0/4] ses: simple subenclosure support Hannes Reinecke
2017-08-15 8:21 ` [PATCH 1/4] scsi: Fixup ses page check Hannes Reinecke
2017-08-17 0:24 ` Martin K. Petersen
2017-08-15 8:21 ` [PATCH 2/4] ses: check return code from ses_recv_diag() Hannes Reinecke
2017-08-15 8:21 ` [PATCH 3/4] ses: Fixup error message 'failed to get diagnostic page 0xffffffea' Hannes Reinecke
2017-08-15 8:21 ` [PATCH 4/4] ses: make page2 support optional Hannes Reinecke
2017-08-17 0:28 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3qjox4z.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox