From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Guilherme G. Piccoli" <gpiccoli@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, raphasil@linux.vnet.ibm.com,
james.smart@broadcom.com, dick.kennedy@broadcom.com,
jsmart2021@gmail.com
Subject: Re: [PATCH] lpfc: Fix NULL pointer dereference during PCI error recovery
Date: Wed, 17 May 2017 20:21:04 -0400 [thread overview]
Message-ID: <yq1y3tv6mmn.fsf@oracle.com> (raw)
In-Reply-To: <20170517220217.28337-1-gpiccoli@linux.vnet.ibm.com> (Guilherme G. Piccoli's message of "Wed, 17 May 2017 19:02:17 -0300")
Guilherme,
> Recent commit on patchset "lpfc updates for 11.2.0.14" fixed an issue
> about dereferencing a NULL pointer on port reset. The specific commit,
> named "lpfc: Fix system crash when port is reset.", is missing a check
> against NULL pointer on lpfc_els_flush_cmd() though.
>
> Since we destroy the queues on adapter resets, like in PCI error
> recovery path, we need the validation present on this patch in order
> to avoid a NULL pointer dereference when trying to flush commands of
> ELS wq, after it has been destroyed (which would lead to a kernel
> oops).
Applied to 4.12/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2017-05-18 0:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:02 [PATCH] lpfc: Fix NULL pointer dereference during PCI error recovery Guilherme G. Piccoli
2017-05-18 0:21 ` Martin K. Petersen [this message]
2017-05-18 13:35 ` Guilherme G. Piccoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1y3tv6mmn.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=dick.kennedy@broadcom.com \
--cc=gpiccoli@linux.vnet.ibm.com \
--cc=james.smart@broadcom.com \
--cc=jsmart2021@gmail.com \
--cc=linux-scsi@vger.kernel.org \
--cc=raphasil@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox