Re: [PATCH] Don't register integrity profile for disabled disks

Martin K. Petersen
2008-08-06T18:47:13Z

>>>>> "James" == James Bottomley <James.Bottomley@HansenPartnership.com> writes:

James> This is a possible thing to have happen for devices with SCSI-2
James> reservations ... and that's not a permanenet condition. When
James> the reservation is released, tools usually do a BLKRRPART, but
James> that won't pick up the DIF information ... perhaps this should
James> be in sd_revalidate_disk?

sd_revalidate_disk can be called before the gendisk exists so I can't
register the profile from there. At one point I tried shuffling
add_disk and revalidate in sd_probe but that caused problems with
sysfs.

I haven't tried reordering since the SCSI sysfs revamp. I'll try that
out so just drop the patch for now. It's mostly cosmetic anyway.

--
Martin K. Petersen Oracle Linux Engineering