From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: mwilck@suse.com, bvanassche@acm.org, hch@lst.de,
martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Subject: Re: [PATCH 1/1] scsi: sd: Fix sshdr use in sd_suspend_common
Date: Wed, 08 Nov 2023 21:47:52 -0500 [thread overview]
Message-ID: <yq1zfzn4p8a.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20231106231304.5694-2-michael.christie@oracle.com> (Mike Christie's message of "Mon, 6 Nov 2023 17:13:04 -0600")
Mike,
> If scsi_execute_cmd returns < 0, it doesn't initialize the sshdr, so
> we shouldn't access the sshdr. If it returns 0, then the cmd executed
> successfully, so there is no need to check the sshdr. sd_sync_cache
> will only access the sshdr if it's been setup because it calls
> scsi_status_is_check_condition before accessing it. However, the
> sd_sync_cache caller, sd_suspend_common, does not check.
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
prev parent reply other threads:[~2023-11-09 2:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 23:13 [PATCH 0/1] scsi: Fix sshdr use wrap up Mike Christie
2023-11-06 23:13 ` [PATCH 1/1] scsi: sd: Fix sshdr use in sd_suspend_common Mike Christie
2023-11-08 7:22 ` Christoph Hellwig
2023-11-09 2:47 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1zfzn4p8a.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=bvanassche@acm.org \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.christie@oracle.com \
--cc=mwilck@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox