* [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments
@ 2017-03-23 10:49 kusumi.tomohiro
2017-03-24 23:21 ` Subhash Jadavani
2017-03-28 1:56 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: kusumi.tomohiro @ 2017-03-23 10:49 UTC (permalink / raw)
To: vinholikatti, linux-scsi; +Cc: Tomohiro Kusumi
From: Tomohiro Kusumi <tkusumi@tuxera.com>
These aren't really falling through to anywhere meaningful.
Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
drivers/scsi/ufs/ufshcd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index dc6efbd..b7e5128 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -553,15 +553,14 @@ static inline u32 ufshcd_get_intr_mask(struct ufs_hba *hba)
case UFSHCI_VERSION_10:
intr_mask = INTERRUPT_MASK_ALL_VER_10;
break;
- /* allow fall through */
case UFSHCI_VERSION_11:
case UFSHCI_VERSION_20:
intr_mask = INTERRUPT_MASK_ALL_VER_11;
break;
- /* allow fall through */
case UFSHCI_VERSION_21:
default:
intr_mask = INTERRUPT_MASK_ALL_VER_21;
+ break;
}
return intr_mask;
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments
2017-03-23 10:49 [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments kusumi.tomohiro
@ 2017-03-24 23:21 ` Subhash Jadavani
2017-03-28 1:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Subhash Jadavani @ 2017-03-24 23:21 UTC (permalink / raw)
To: kusumi.tomohiro
Cc: vinholikatti, linux-scsi, Tomohiro Kusumi, linux-scsi-owner
On 2017-03-23 03:49, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> These aren't really falling through to anywhere meaningful.
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index dc6efbd..b7e5128 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -553,15 +553,14 @@ static inline u32 ufshcd_get_intr_mask(struct
> ufs_hba *hba)
> case UFSHCI_VERSION_10:
> intr_mask = INTERRUPT_MASK_ALL_VER_10;
> break;
> - /* allow fall through */
> case UFSHCI_VERSION_11:
> case UFSHCI_VERSION_20:
> intr_mask = INTERRUPT_MASK_ALL_VER_11;
> break;
> - /* allow fall through */
> case UFSHCI_VERSION_21:
> default:
> intr_mask = INTERRUPT_MASK_ALL_VER_21;
> + break;
> }
>
> return intr_mask;
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments
2017-03-23 10:49 [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments kusumi.tomohiro
2017-03-24 23:21 ` Subhash Jadavani
@ 2017-03-28 1:56 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-03-28 1:56 UTC (permalink / raw)
To: kusumi.tomohiro; +Cc: vinholikatti, linux-scsi, Tomohiro Kusumi
kusumi.tomohiro@gmail.com writes:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> These aren't really falling through to anywhere meaningful.
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
Applied to 4.12/scsi-queue.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-03-28 1:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-23 10:49 [PATCH] scsi: ufs: fix wrong/ambiguous fall through comments kusumi.tomohiro
2017-03-24 23:21 ` Subhash Jadavani
2017-03-28 1:56 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).