Re: [PATCH 2.6.1] Add CRC32C chksums to crypto and lib routines

[Clay Haapala <chaapala@cisco.com>]

On Tue, 3 Feb 2004, James Morris told this:
> On Tue, 3 Feb 2004, Clay Haapala wrote:
> 
>> If this patch looks good, I'd like it accepted so we can submit
>> code iSCSI driver code that makes use of it.  This may be a good
>> time, since the crypto SHA code is getting a little scrutiny right
>> now.
> 
> This will need to wait until 2.6.2 is released, and will you also
> please submit the iSCSI change for review?
> 
Thanks, Dave, for setting me straight on not posting mondo patches to
lkml. :-)

The 4.0.0.4 version of the driver, with the crypto CRC calls omitted,
has been submitted for review by the scsi maintainers.  Here is link
to a "preview" patch with the calls to the crypto CRC32C module back
in, but without any of their latest comments incorporated:

  http://home.mn.rr.com/haapi/iSCSI/iscsi-4.0.0.4-with-crypto.patch.bz2

iscsi-crc.{c,h} are just wrappers for code using the previous private
implementation.  iscsi-recv-pdu.c and iscsi-xmit-pdu.c have the code
which processes scatterlists and make calls to the crypto CRC32C
routines in the other patch.

This code has been tested successfully on 2.6.1 with udev-0.15 and late-model
sysfs, hotplug, and klibc.  The patch also contains the iscsi utilities
code, if you want to go the whole nine yards.
-- 
Clay Haapala (chaapala@cisco.com) Cisco Systems SRBU +1 763-398-1056
   6450 Wedgwood Rd, Suite 130 Maple Grove MN 55311 PGP: C89240AD
    Minnesota is a very agreeable state.  Lately even Celsius and
                   Fahrenheit have tended to agree.