From: Chunbo Luo <chunbo.luo@windriver.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
chunbo.luo@windriver.com
Subject: [PATCH 2/2] sctp: fix heartbeat count of path failure
Date: Wed, 19 Aug 2009 07:01:08 +0000 [thread overview]
Message-ID: <1250665268-29770-2-git-send-email-chunbo.luo@windriver.com> (raw)
In-Reply-To: <1250665268-29770-1-git-send-email-chunbo.luo@windriver.com>
RFC4960 Section 8.2 defined that the transport should enter INACTIVE
state only when the value in the error counter exceeds the protocol
parameter 'Path.Max.Retrans' of that destination address. This means
that the transport should enter INACTIVE state after pathmaxrxt+1
heartbeats are not acknowledged.
Signed-off-by: Chunbo Luo <chunbo.luo@windriver.com>
---
net/sctp/sm_sideeffect.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c
index 86426aa..0e2e269 100644
--- a/net/sctp/sm_sideeffect.c
+++ b/net/sctp/sm_sideeffect.c
@@ -447,7 +447,7 @@ static void sctp_do_8_2_transport_strike(struct sctp_association *asoc,
asoc->overall_error_count++;
if (transport->state != SCTP_INACTIVE &&
- (transport->error_count++ >= transport->pathmaxrxt)) {
+ (transport->error_count++ > transport->pathmaxrxt)) {
SCTP_DEBUG_PRINTK_IPADDR("transport_strike:association %p",
" transport IP: port:%d failed.\n",
asoc,
--
1.6.4
next prev parent reply other threads:[~2009-08-19 7:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-19 7:01 [PATCH 1/2] sctp: fix heartbeat count of association failure Chunbo Luo
2009-08-19 7:01 ` Chunbo Luo [this message]
2009-08-19 14:48 ` [PATCH 2/2] sctp: fix heartbeat count of path failure Vlad Yasevich
2009-08-20 1:36 ` Luo Chunbo
2009-08-20 14:10 ` Vlad Yasevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1250665268-29770-2-git-send-email-chunbo.luo@windriver.com \
--to=chunbo.luo@windriver.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).