From: David Miller <davem@davemloft.net>
To: vladislav.yasevich@hp.com
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org
Subject: Re: [PATCH] sctp: Set source addresses on the association before
Date: Sat, 14 Nov 2009 03:57:09 +0000 [thread overview]
Message-ID: <20091113.195709.164224314.davem@davemloft.net> (raw)
In-Reply-To: <1257879454-31661-1-git-send-email-vladislav.yasevich@hp.com>
From: Vlad Yasevich <vladislav.yasevich@hp.com>
Date: Tue, 10 Nov 2009 13:57:34 -0500
> Recent commit 8da645e101a8c20c6073efda3c7cc74eec01b87f
> sctp: Get rid of an extra routing lookup when adding a transport
> introduced a regression in the connection setup. The behavior was
> different between IPv4 and IPv6. IPv4 case ended up working because the
> route lookup routing returned a NULL route, which triggered another
> route lookup later in the output patch that succeeded. In the IPv6 case,
> a valid route was returned for first call, but we could not find a valid
> source address at the time since the source addresses were not set on the
> association yet. Thus resulted in a hung connection.
>
> The solution is to set the source addresses on the association prior to
> adding peers.
>
> Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Applied.
prev parent reply other threads:[~2009-11-14 3:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 18:57 [PATCH] sctp: Set source addresses on the association before adding transports Vlad Yasevich
2009-11-11 21:54 ` [PATCH] sctp: Set socket source address when additing first transport Vlad Yasevich
2009-11-14 3:57 ` [PATCH] sctp: Set socket source address when additing first David Miller
2009-11-14 3:57 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091113.195709.164224314.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).